Remove closing http client after logging out (#18)

* Remove closing http client after logging out Fixes #17. * Fix Codecov flag carryforward config
leancodepl · Jan 12, 2021 · 7469aa8 · 7469aa8
1 parent 707de44
commit 7469aa8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/codecov.yml b/codecov.yml
@@ -17,8 +17,8 @@ comment:
 
 flags:
   cqrs:
-    paths: packages/cqrs
+    paths: [packages/cqrs]
     carryforward: true
   login_client:
-    paths: packages/login_client
+    paths: [packages/login_client]
     carryforward: true
diff --git a/packages/login_client/CHANGELOG.md b/packages/login_client/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 1.1.1
+
+- Fix closing default HTTP client after logging out.
+
 # 1.1.0
 
 - OAuth2 `clientId` is now required.

diff --git a/packages/login_client/lib/src/login_client.dart b/packages/login_client/lib/src/login_client.dart
@@ -179,7 +179,6 @@ class LoginClient extends http.BaseClient {
     _onCredentialsChanged.add(null);
     await _credentialsStorage.clear();
 
-    _oAuthClient?.close();
     _oAuthClient = null;
   }
 

diff --git a/packages/login_client/pubspec.yaml b/packages/login_client/pubspec.yaml
@@ -1,5 +1,5 @@
 name: login_client
-version: 1.1.0
+version: 1.1.1
 homepage: https://github.com/leancodepl/flutter_corelibrary/tree/master/packages/login_client
 repository: https://github.com/leancodepl/flutter_corelibrary
 description: >-