Migrate to xUnit 3 #725
Open
Migrate to xUnit 3 #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubfijalkowski
changed the base branch from
v9.0-preview
to
feature/central-package-mgmt
Base automatically changed from
feature/central-package-mgmt
to
v9.0-preview
December 20, 2024 12:20
jakubfijalkowski
force-pushed
the
feature/xunit3
branch
from
f3d2342 to
d9c57d2
Compare
test: Run #2061
🎉 All tests passed!🔄 This comment has been updated |
jakubfijalkowski
force-pushed
the
feature/xunit3
branch
from
ca85351 to
d78856b
Compare
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 43 out of 58 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- .config/dotnet-tools.json: Language not supported
- .editorconfig: Language not supported
- .github/workflows/publish_unit_tests.yml: Language not supported
- Directory.Packages.props: Language not supported
- Docker.Directory.Build.props: Language not supported
- LeanCode.CoreLibrary.sln: Language not supported
- src/Testing/LeanCode.IntegrationTestHelpers/LeanCode.IntegrationTestHelpers.csproj: Language not supported
- test/Directory.Build.props: Language not supported
- test/CQRS/LeanCode.CQRS.AspNetCore.Tests/CQRSEndpointsDataSourceTests.cs: Evaluated as low risk
- test/CQRS/LeanCode.CQRS.AspNetCore.Tests/Local/MiddlewareBasedExecutorIntegrationTests.cs: Evaluated as low risk
- test/CQRS/LeanCode.CQRS.AspNetCore.Tests/Middleware/CQRSMiddlewareTestBase.cs: Evaluated as low risk
- test/CQRS/LeanCode.CQRS.MassTransitRelay.Tests/Integration/TestApp.cs: Evaluated as low risk
- test/CQRS/LeanCode.CQRS.MassTransitRelay.Tests/Middleware/EventsPublisherFilterTests.cs: Evaluated as low risk
- test/CQRS/LeanCode.CQRS.MassTransitRelay.Tests/ScopedFiltersTests.cs: Evaluated as low risk
- test/Infrastructure/LeanCode.AuditLogs.Tests/AuditLogsIntegrationTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)
.github/workflows/core_build_publish.yml:93
- Disabling the formatting check might lead to inconsistent code formatting. Ensure this change is intentional.
if: false
.github/workflows/core_build_publish.yml:135
- Removing the installation of trx2junit and related test result conversion might affect how test results are processed and reported. Ensure this change is intentional.
- name: Install trx2junit
test/Infrastructure/LeanCode.Azure.Tests/AzureStorageAuditLogIntegrationTests.cs:31
- Using 'https://UNSET.table.core.windows.net/' as a default value for AzureTableStorageServiceUriKey might mask configuration issues. Consider handling missing environment variables more explicitly.
Environment.GetEnvironmentVariable(Env.AzureTableStorageServiceUriKey) ?? "https://UNSET.table.core.windows.net/"
| @@ -19,18 +20,21 @@ public AzureStorageAuditLogIntegrationTests() | |||
| { | |||
| var credential = Env.GetTokenCredential(); | |||
| blobServiceClient = new BlobServiceClient( | |||
| new Uri(Environment.GetEnvironmentVariable(Env.AzureBlobStorageServiceUriKey)!), | |||
| new Uri(Environment.GetEnvironmentVariable(Env.AzureBlobStorageServiceUriKey) ?? "https://unset"), | |||
There was a problem hiding this comment.
Using 'https://unset' as a default value for AzureBlobStorageServiceUriKey might mask configuration issues. Consider handling missing environment variables more explicitly.
Suggested change
| new Uri(Environment.GetEnvironmentVariable(Env.AzureBlobStorageServiceUriKey) ?? "https://unset"), | |
| new Uri(Environment.GetEnvironmentVariable(Env.AzureBlobStorageServiceUriKey) ?? throw new InvalidOperationException("AzureBlobStorageServiceUriKey is not set")), |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.