Remove bcc emails #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is correct (and pretty obvious in hindsight) but why is the former? You were after all passing one To and one Bcc emails so the requirement would be satisfied, wouldn't it? |
|
The client does not accept passing explicitly empty list of emails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind this change:
Sending CC/BCC in this case do not give us much value, since we want to inform the back-office team only. Their emails are most likely already known to everyone within the organization.
Current implementation does not work (at least one email is required by the API) and I don't see value in fixing it (I know - one
if). Removing it benefits us in simpler configuration => dev won't need to thing which emails should be to/cc/bcc at all.