Low rate email to admin #6
Conversation
backend/src/LeanCode.AppRating/Configuration/AdminConfiguration.cs
Outdated
Show resolved
Hide resolved
backend/src/LeanCode.AppRating/MassTransintRegistrationConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
backend/src/LeanCode.AppRating/Processes/SendEmailOnLowRateSubmitted.cs
Outdated
Show resolved
Hide resolved
backend/src/LeanCode.AppRating/Processes/SendEmailOnLowRateSubmitted.cs
Outdated
Show resolved
Hide resolved
backend/src/LeanCode.AppRating/Processes/SendEmailOnLowRateSubmitted.cs
Outdated
Show resolved
Hide resolved
| @@ -62,6 +71,8 @@ public Task ExecuteAsync(HttpContext context, SubmitAppRating command) | |||
| ) | |||
| ); | |||
|
|
|||
| publishEndpoint.Publish(new RateSubmitted<TUserId>(userId, command.Rating)); | |||
There was a problem hiding this comment.
Shouldn't this be awaited?
There was a problem hiding this comment.
My bad. You're right. It should. will fix
There was a problem hiding this comment.
This is why having Async suffix is useful, one does not need to remember if every single method out there returns an awaitable or not 🙈
There was a problem hiding this comment.
Shouldn't Roslyn catch this?
There was a problem hiding this comment.
I believe I configured something incorrectly. Will fix
backend/src/LeanCode.AppRating/Processes/SendEmailOnLowRateSubmitted.cs
Outdated
Show resolved
Hide resolved
backend/src/LeanCode.AppRating/EmailViewModels/LowRateSubmittedEmail.cs
Outdated
Show resolved
Hide resolved
backend/src/LeanCode.AppRating/Processes/SendEmailOnLowRateSubmitted.cs
Outdated
Show resolved
Hide resolved
backend/src/LeanCode.AppRating/Processes/SendEmailOnLowRateSubmitted.cs
Outdated
Show resolved
Hide resolved
backend/src/LeanCode.AppRating/Processes/SendEmailOnLowRateSubmitted.cs
Outdated
Show resolved
Hide resolved
lukaszgarstecki
force-pushed
the
feature/low-rate-email
branch
from
feb250b to
d931080
Compare
lukaszgarstecki
force-pushed
the
feature/low-rate-email
branch
from
d931080 to
dd87fb8
Compare
| string LowRatingEmailSubjectKey, | ||
| string FromEmail, | ||
| string[] ToEmails, | ||
| string[] BccEmails |
There was a problem hiding this comment.
I wonder if this will ever be non-empty. :D
| } | ||
| } | ||
|
|
||
| public class AppRatingConsumerDefinition<TConsumer> : ConsumerDefinition<TConsumer> |
There was a problem hiding this comment.
I wonder, on one hand, we allow configuring too much (e.g. BCC, or default locale/culture), on the other, we set some things in stone and disallow any changes (consumer configuration). Where is the "ideal" line between ease of use and usability when it comes to configuring things?
No description provided.