-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI/CD pipeline #2
Conversation
2606d4e
to
453750a
Compare
8551a54
to
a39658e
Compare
a39658e
to
ac304fd
Compare
- name: Extract Artifacts | ||
run: | | ||
for file in artifacts/*.zip; do | ||
if [[ -f "$file" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be more reasonable to enable nullglob
instead of checking every match if it actually exists 🙈
ac304fd
to
fd8bbf8
Compare
ab32304
to
48f4e7b
Compare
3e76b50
to
e23bad8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last suggestion which I somehow must have missed during initial review. But LGTM anyway.
e23bad8
to
4a8a1fb
Compare
No description provided.