Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI/CD pipeline #2

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add CI/CD pipeline #2

merged 1 commit into from
Nov 27, 2023

Conversation

lukaszgarstecki
Copy link
Member

No description provided.

@lukaszgarstecki lukaszgarstecki force-pushed the feature/ci-cd branch 14 times, most recently from 2606d4e to 453750a Compare November 23, 2023 10:01
Copy link

github-actions bot commented Nov 23, 2023

Test Results

8 tests   8 ✔️  15s ⏱️
2 suites  0 💤
2 files    0

Results for commit 4a8a1fb.

♻️ This comment has been updated with latest results.

@lukaszgarstecki lukaszgarstecki force-pushed the feature/ci-cd branch 10 times, most recently from 8551a54 to a39658e Compare November 23, 2023 11:48
@lukaszgarstecki lukaszgarstecki marked this pull request as ready for review November 23, 2023 12:28
.github/workflows/build_publish.yml Outdated Show resolved Hide resolved
.github/workflows/build_publish.yml Outdated Show resolved Hide resolved
.github/workflows/build_publish.yml Outdated Show resolved Hide resolved
.github/workflows/build_publish.yml Outdated Show resolved Hide resolved
.github/workflows/build_publish.yml Outdated Show resolved Hide resolved
.github/workflows/build_publish.yml Show resolved Hide resolved
.github/workflows/build_publish.yml Outdated Show resolved Hide resolved
.github/workflows/build_publish.yml Outdated Show resolved Hide resolved
- name: Extract Artifacts
run: |
for file in artifacts/*.zip; do
if [[ -f "$file" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be more reasonable to enable nullglob instead of checking every match if it actually exists 🙈

@lukaszgarstecki lukaszgarstecki force-pushed the feature/ci-cd branch 2 times, most recently from ab32304 to 48f4e7b Compare November 24, 2023 14:57
@lukaszgarstecki lukaszgarstecki force-pushed the feature/ci-cd branch 2 times, most recently from 3e76b50 to e23bad8 Compare November 27, 2023 12:15
Copy link
Member

@Saancreed Saancreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion which I somehow must have missed during initial review. But LGTM anyway.

.github/workflows/build_publish.yml Outdated Show resolved Hide resolved
@lukaszgarstecki lukaszgarstecki merged commit 349da0d into main Nov 27, 2023
3 checks passed
@lukaszgarstecki lukaszgarstecki deleted the feature/ci-cd branch November 27, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants