Merge pull request #8 from leancodepl/fix/rating-inclusive

Fix LowRatingUpperBoundInclusive handling
leancodepl · Dec 1, 2023 · 37a9e1a · 37a9e1a
2 parents ad3f5cc + 17c32e0
commit 37a9e1a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/backend/src/LeanCode.AppRating/Handlers/SubmitAppRatingCH.cs b/backend/src/LeanCode.AppRating/Handlers/SubmitAppRatingCH.cs
@@ -76,7 +76,7 @@ public async Task ExecuteAsync(HttpContext context, SubmitAppRating command)
                 )
             );
 
-        if (command.Rating < appRatingReportsConfiguration.LowRatingUpperBoundInclusive)
+        if (command.Rating <= appRatingReportsConfiguration.LowRatingUpperBoundInclusive)
         {
             await publishEndpoint.Publish(
                 new LowRateSubmitted<TUserId>(userId, command.Rating, command.AdditionalComment),

diff --git a/backend/tests/LeanCode.AppRating.IntegrationTests/Tests/SubmitReviewTests.cs b/backend/tests/LeanCode.AppRating.IntegrationTests/Tests/SubmitReviewTests.cs
@@ -83,7 +83,7 @@ private async Task EnsureLowRatingSubmittedEmailSent()
         await App.Command.RunSuccessAsync(
             new SubmitAppRating
             {
-                Rating = 1.0,
+                Rating = 2.0,
                 AdditionalComment = new string('a', 200),
                 AppVersion = "1.23.456",
                 Platform = PlatformDTO.Android,