Use fake level for JEI

[uecasm]

Closes #10302 (once ported)

Changes proposed in this pull request

• Use a fake level when creating citizens for JEI

Testing

• Yes I tested this before submitting it.
• I also did a multiplayer test.

Review please (should port)

[Nightenom]

There is technically breaking change logic-wise in latest fakelevel backport, so please update
Use singleblockfakelevel, probably with blockstate of air
Don't forget to override getRealLevel as redirect to mc.instance.level

[someaddons]

why onlyin? dont think we should use that in 1.21

[uecasm]

Paranoia, mostly. Since it's using client-only classes it must not be loaded in the server jar. Though that should be the case even without this, it seems safer to make it explicit.

[pietro-lopes]

Please, check how you are instancing this LivingEntity if you would need to use a fake level here too.

minecolonies/src/main/java/com/minecolonies/api/crafting/GenericRecipe.java

Line 96 in 7066c5c

private final LivingEntity requiredEntity;

This is where it starts:

minecolonies/src/main/java/com/minecolonies/core/compatibility/jei/JEIPlugin.java

Line 131 in 7066c5c

final ClientLevel level = Objects.requireNonNull(Minecraft.getInstance().level);

[uecasm]

Please, check how you are instancing this LivingEntity if you would need to use a fake level here too.

Good catch, thanks.

Changes made

[Nightenom]

Hmm, out of scope of this PR: but why do we pass instantiated entity in the first place?

[uecasm]

Because (a) that's what the entity renderer wants in order to draw an entity, and (b) other places need to query various instance methods that only exist on the instantiated entity.

[pietro-lopes]

Honestly, if possible, I prefer WeakReference instead of cached by magic number 2 minutes

[uecasm]

Minecraft GCs all the time, so a WeakReference is almost identical to not caching it at all. And entities are not sufficiently lightweight for that to seem justifiable.