Fix a crash upon deserialization of equipment types in recipes #10221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someaddons
approved these changes
Sep 15, 2024
Raycoms
approved these changes
Sep 15, 2024
Raycoms
added a commit
that referenced
this pull request
Sep 16, 2024
Because the new tool type is called "none" instead of an empty string it becomes unable to be loaded, added fallback code so this can safely load again. Updates a bunch of jdoc code to remove capital casing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10220
Changes proposed in this pull request
Testing
Review please