Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/warehouse issue #10218

Merged
merged 4 commits into from
Sep 15, 2024
Merged

Fix/warehouse issue #10218

merged 4 commits into from
Sep 15, 2024

Conversation

Raycoms
Copy link
Contributor

@Raycoms Raycoms commented Sep 14, 2024

Closes #10208
Closes #

Changes proposed in this pull request

  • Fix warehouse accepting task it has no items for

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@@ -791,7 +787,7 @@ public static int hasBuildingEnoughElseCount(@NotNull final IBuilding provider,
totalCount += ((TileEntityRack) entity).getItemCount(stack);
}

if (totalCount > count)
if (totalCount >= count)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

someaddons
someaddons previously approved these changes Sep 15, 2024
@Raycoms Raycoms merged commit bf1dc33 into version/main Sep 15, 2024
4 checks passed
@Raycoms Raycoms deleted the fix/warehouse-issue branch September 15, 2024 13:11
Raycoms added a commit that referenced this pull request Sep 16, 2024
Fix warehouse accepting task it has no items for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The warehouse is still taking items from other warehouses to fulfill requests.
2 participants