Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colony expedition system #10113

Closed

Conversation

Thodor12
Copy link
Contributor

Changes proposed in this pull request:

  • Expeditions are virtualized events that can be started from a new visitor that will appear at the townhall. You may talk to them and begin preparing for an expedition.
    You will have to give them a given amount of goods and assign one or more guards to travel alongside them.
  • Current and past expeditions can be viewed from the townhall, you will be able to see what you provided them, which guards were sent along, who died (if any), and everything they managed to find.
  • The system is highly modifiable through the means of datapacks, from the expedition types to the loot tables.

Currently a draft, mostly looking for initial implementation feedback and feedback on the actual loot tables that come with the initial expeditions.

[ ] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.

Review please

# Conflicts:
#	src/api/java/com/minecolonies/api/colony/IVisitorData.java
#	src/main/java/com/minecolonies/apiimp/initializer/EntityInitializer.java
#	src/main/java/com/minecolonies/core/MineColonies.java
#	src/main/java/com/minecolonies/core/colony/interactionhandling/RecruitmentInteraction.java
#	src/main/java/com/minecolonies/core/colony/managers/CitizenManager.java
#	src/main/java/com/minecolonies/core/colony/managers/VisitorManager.java
#	src/main/java/com/minecolonies/core/datalistener/CustomVisitorListener.java
#	src/main/java/com/minecolonies/core/entity/ai/visitor/EntityAIVisitor.java
#	src/main/java/com/minecolonies/core/entity/citizen/VisitorCitizen.java
# Conflicts:
#	src/main/java/com/minecolonies/api/IMinecoloniesAPI.java
#	src/main/java/com/minecolonies/api/MinecoloniesAPIProxy.java
#	src/main/java/com/minecolonies/apiimp/CommonMinecoloniesAPIImpl.java
#	src/main/java/com/minecolonies/apiimp/initializer/EntityInitializer.java
#	src/main/java/com/minecolonies/core/entity/visitor/VisitorCitizen.java
# Conflicts:
#	src/main/java/com/minecolonies/api/colony/managers/interfaces/IExpeditionManager.java
#	src/main/java/com/minecolonies/core/colony/managers/VisitorManager.java
# Conflicts:
#	src/main/java/com/minecolonies/core/entity/visitor/VisitorCitizen.java
# Conflicts:
#	src/main/java/com/minecolonies/core/entity/visitor/VisitorCitizen.java
@Thodor12 Thodor12 closed this Sep 29, 2024
@Thodor12 Thodor12 deleted the feature/colony_expeditions_120 branch September 29, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant