Skip to content

Commit

Permalink
Merge branch 'fix-typ-header' into 3.0
Browse files Browse the repository at this point in the history
  • Loading branch information
lcobucci committed Oct 1, 2015
2 parents ff4c2b1 + b4e0fe0 commit 0935669
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion src/Signer/BaseSigner.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ abstract class BaseSigner implements Signer
*/
public function modifyHeader(array &$headers)
{
$headers['typ'] = 'JWS';
$headers['alg'] = $this->getAlgorithmId();
}

Expand Down
6 changes: 3 additions & 3 deletions test/unit/Signer/BaseSignerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ protected function setUp()
*
* @covers Lcobucci\JWT\Signer\BaseSigner::modifyHeader
*/
public function modifyHeaderShouldChangeAlgorithmAndType()
public function modifyHeaderShouldChangeAlgorithm()
{
$headers = [];
$headers = ['typ' => 'JWT'];

$this->signer->modifyHeader($headers);

$this->assertEquals($headers['typ'], 'JWS');
$this->assertEquals($headers['typ'], 'JWT');
$this->assertEquals($headers['alg'], 'TEST123');
}

Expand Down

0 comments on commit 0935669

Please sign in to comment.