Apply type guards also on old Builder#set()

lcobucci · Nov 27, 2020 · 0542295 · 0542295
1 parent 317e4c9
commit 0542295
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 1 deletion.
diff --git a/src/Builder.php b/src/Builder.php
@@ -451,7 +451,7 @@ private function forwardCallToCorrectClaimMethod($name, $value)
      */
     public function set($name, $value)
     {
-        return $this->configureClaim($name, $value);
+        return $this->forwardCallToCorrectClaimMethod($name, $value);
     }
 
     /**

diff --git a/test/unit/BuilderTest.php b/test/unit/BuilderTest.php
@@ -604,6 +604,46 @@ public function withClaimShouldSendDeprecationNoticeWhenTryingToConfigureARegist
         self::assertEquals($expected, $token->claims()->get($name));
     }
 
+
+    /**
+     * @test
+     *
+     * @param string $name
+     * @param mixed $value
+     * @param mixed $expected
+     * @param null|string $otherMessage
+     *
+     * @covers ::__construct
+     * @covers ::set
+     * @covers ::canOnlyBeUsedAfter
+     * @covers ::configureClaim
+     * @covers ::convertItems
+     * @covers ::convertToDate
+     * @covers ::getToken
+     * @covers ::setRegisteredClaim
+     * @covers ::createSignature
+     * @covers ::expiresAt
+     * @covers ::issuedBy
+     * @covers ::identifiedBy
+     * @covers ::permittedFor
+     * @covers ::forwardCallToCorrectClaimMethod
+     * @covers ::issuedAt
+     *
+     * @dataProvider dataWithClaimDeprecationNotice
+     */
+    public function setShouldSendDeprecationNoticeWhenTryingToConfigureARegisteredClaim($name, $value, $expected, $otherMessage = null)
+    {
+        if ($otherMessage) {
+            $this->expectDeprecation($otherMessage);
+        }
+
+        $token = $this->createBuilder()
+            ->set($name, $value)
+            ->getToken(new None(), Key\InMemory::plainText(''));
+
+        self::assertEquals($expected, $token->claims()->get($name));
+    }
+
     public function dataWithClaimDeprecationNotice()
     {
         $now = time();