Merge pull request #65 from lcobucci/simplify-coverage-annotations

Simplify coverage annotations
lcobucci · Oct 1, 2020 · 361f703 · 361f703
2 parents aa54fc8 + de4b20f
commit 361f703
Show file tree

Hide file tree

Showing 7 changed files with 109 additions and 162 deletions.
diff --git a/test/Compiler/DumpXmlContainerTest.php b/test/Compiler/DumpXmlContainerTest.php
@@ -10,6 +10,7 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag as Parameters;
 
+/** @coversDefaultClass \Lcobucci\DependencyInjection\Compiler\DumpXmlContainer */
 final class DumpXmlContainerTest extends TestCase
 {
     /** @var ConfigCacheInterface&MockObject */
@@ -24,8 +25,8 @@ public function createConfig(): void
     /**
      * @test
      *
-     * @covers \Lcobucci\DependencyInjection\Compiler\DumpXmlContainer::__construct
-     * @covers \Lcobucci\DependencyInjection\Compiler\DumpXmlContainer::process
+     * @covers ::__construct
+     * @covers ::process
      */
     public function processShouldBeSkippedWhenDevModeIsNotEnabled(): void
     {
@@ -42,8 +43,8 @@ public function processShouldBeSkippedWhenDevModeIsNotEnabled(): void
     /**
      * @test
      *
-     * @covers \Lcobucci\DependencyInjection\Compiler\DumpXmlContainer::__construct
-     * @covers \Lcobucci\DependencyInjection\Compiler\DumpXmlContainer::process
+     * @covers ::__construct
+     * @covers ::process
      */
     public function processShouldBeSkippedWhenCacheIsFresh(): void
     {
@@ -60,8 +61,8 @@ public function processShouldBeSkippedWhenCacheIsFresh(): void
     /**
      * @test
      *
-     * @covers \Lcobucci\DependencyInjection\Compiler\DumpXmlContainer::__construct
-     * @covers \Lcobucci\DependencyInjection\Compiler\DumpXmlContainer::process
+     * @covers ::__construct
+     * @covers ::process
      */
     public function processShouldDumpTheContainerUsingTheXmlDumper(): void
     {

diff --git a/test/Compiler/ParameterBagTest.php b/test/Compiler/ParameterBagTest.php
@@ -6,13 +6,14 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 
+/** @coversDefaultClass \Lcobucci\DependencyInjection\Compiler\ParameterBag */
 final class ParameterBagTest extends TestCase
 {
     /**
      * @test
      *
-     * @covers \Lcobucci\DependencyInjection\Compiler\ParameterBag::__construct
-     * @covers \Lcobucci\DependencyInjection\Compiler\ParameterBag::set
+     * @covers ::__construct
+     * @covers ::set
      */
     public function setShouldConfigureAParameter(): void
     {
@@ -25,34 +26,34 @@ public function setShouldConfigureAParameter(): void
     /**
      * @test
      *
-     * @covers \Lcobucci\DependencyInjection\Compiler\ParameterBag::__construct
-     * @covers \Lcobucci\DependencyInjection\Compiler\ParameterBag::get
+     * @covers ::__construct
+     * @covers ::get
      */
     public function getShouldReturnTheValueOfTheParameter(): void
     {
         $pass = new ParameterBag(['test' => 1]);
 
-        self::assertEquals(1, $pass->get('test'));
+        self::assertSame(1, $pass->get('test'));
     }
 
     /**
      * @test
      *
-     * @covers \Lcobucci\DependencyInjection\Compiler\ParameterBag::get
+     * @covers ::get
      *
      * @uses \Lcobucci\DependencyInjection\Compiler\ParameterBag::__construct
      */
     public function getShouldReturnTheDefaultValueWhenParameterDoesNotExist(): void
     {
         $pass = new ParameterBag();
 
-        self::assertEquals(1, $pass->get('test', 1));
+        self::assertSame(1, $pass->get('test', 1));
     }
 
     /**
      * @test
      *
-     * @covers \Lcobucci\DependencyInjection\Compiler\ParameterBag::process
+     * @covers ::process
      *
      * @uses \Lcobucci\DependencyInjection\Compiler\ParameterBag::__construct
      */
@@ -62,6 +63,6 @@ public function invokeShouldAppendAllConfiguredParametersOnTheBuilder(): void
         $pass    = new ParameterBag(['test' => 1]);
 
         $pass->process($builder);
-        self::assertEquals(1, $builder->getParameter('test'));
+        self::assertSame(1, $builder->getParameter('test'));
     }
 }
diff --git a/test/CompilerTest.php b/test/CompilerTest.php
@@ -25,6 +25,15 @@
 use function random_bytes;
 use function realpath;
 
+/**
+ * @covers \Lcobucci\DependencyInjection\Compiler
+ *
+ * @uses \Lcobucci\DependencyInjection\Compiler\ParameterBag
+ * @uses \Lcobucci\DependencyInjection\Config\ContainerConfiguration
+ * @uses \Lcobucci\DependencyInjection\Generator
+ * @uses \Lcobucci\DependencyInjection\Generators\Yaml
+ * @uses \Lcobucci\DependencyInjection\Testing\MakeServicesPublic
+ */
 final class CompilerTest extends TestCase
 {
     private const EXPECTED_FILES = [
@@ -81,17 +90,7 @@ public function cleanUpDumpDirectory(): void
         exec('rm -rf ' . realpath($this->dumpDir . '/../../'));
     }
 
-    /**
-     * @test
-     *
-     * @covers \Lcobucci\DependencyInjection\Compiler
-     *
-     * @uses \Lcobucci\DependencyInjection\Compiler\ParameterBag
-     * @uses \Lcobucci\DependencyInjection\Config\ContainerConfiguration
-     * @uses \Lcobucci\DependencyInjection\Generator
-     * @uses \Lcobucci\DependencyInjection\Generators\Yaml
-     * @uses \Lcobucci\DependencyInjection\Testing\MakeServicesPublic
-     */
+    /** @test */
     public function compileShouldCreateMultipleFiles(): void
     {
         $compiler = new Compiler();
@@ -107,17 +106,7 @@ public function compileShouldCreateMultipleFiles(): void
         }
     }
 
-    /**
-     * @test
-     *
-     * @covers \Lcobucci\DependencyInjection\Compiler
-     *
-     * @uses \Lcobucci\DependencyInjection\Compiler\ParameterBag
-     * @uses \Lcobucci\DependencyInjection\Config\ContainerConfiguration
-     * @uses \Lcobucci\DependencyInjection\Generator
-     * @uses \Lcobucci\DependencyInjection\Generators\Yaml
-     * @uses \Lcobucci\DependencyInjection\Testing\MakeServicesPublic
-     */
+    /** @test */
     public function compileShouldTrackChangesOnTheConfigurationFile(): void
     {
         $compiler = new Compiler();
@@ -129,17 +118,7 @@ public function compileShouldTrackChangesOnTheConfigurationFile(): void
         );
     }
 
-    /**
-     * @test
-     *
-     * @covers \Lcobucci\DependencyInjection\Compiler
-     *
-     * @uses \Lcobucci\DependencyInjection\Compiler\ParameterBag
-     * @uses \Lcobucci\DependencyInjection\Config\ContainerConfiguration
-     * @uses \Lcobucci\DependencyInjection\Generator
-     * @uses \Lcobucci\DependencyInjection\Generators\Yaml
-     * @uses \Lcobucci\DependencyInjection\Testing\MakeServicesPublic
-     */
+    /** @test */
     public function compileShouldAllowForLazyServices(): void
     {
         file_put_contents(
@@ -156,15 +135,7 @@ public function compileShouldAllowForLazyServices(): void
         self::assertCount(count($expectedFiles) + 1, $generatedFiles);
     }
 
-    /**
-     * @test
-     *
-     * @covers \Lcobucci\DependencyInjection\Compiler
-     *
-     * @uses \Lcobucci\DependencyInjection\Compiler\ParameterBag
-     * @uses \Lcobucci\DependencyInjection\Config\ContainerConfiguration
-     * @uses \Lcobucci\DependencyInjection\Generator
-     */
+    /** @test */
     public function compilationShouldBeSkippedWhenFileAlreadyExists(): void
     {
         file_put_contents($this->dumpDir . '/AppContainer.php', 'testing');