-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adjustTime to FrozenClock #689
Merged
lcobucci
merged 1 commit into
lcobucci:3.3.x
from
lgrossi:lucas/minor-frozen-clock-helpers
Sep 24, 2024
Merged
Add adjustTime to FrozenClock #689
lcobucci
merged 1 commit into
lcobucci:3.3.x
from
lgrossi:lucas/minor-frozen-clock-helpers
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrossi
force-pushed
the
lucas/minor-frozen-clock-helpers
branch
from
July 4, 2024 09:45
7f6238c
to
efba1f7
Compare
lcobucci
requested changes
Jul 4, 2024
lgrossi
force-pushed
the
lucas/minor-frozen-clock-helpers
branch
from
July 4, 2024 11:16
efba1f7
to
c6f552d
Compare
lgrossi
changed the title
Add modify and default constructor to FrozenClock
Add adjustTime to FrozenClock
Jul 4, 2024
lgrossi
force-pushed
the
lucas/minor-frozen-clock-helpers
branch
3 times, most recently
from
July 4, 2024 11:26
a724f49
to
35c4690
Compare
lcobucci
requested changes
Sep 24, 2024
lcobucci
force-pushed
the
lucas/minor-frozen-clock-helpers
branch
from
September 24, 2024 20:37
35c4690
to
47cb7d3
Compare
lcobucci
approved these changes
Sep 24, 2024
@lgrossi thanks! |
lcobucci
reviewed
Sep 24, 2024
throw new InvalidArgumentException('The given modifier is invalid'); | ||
} | ||
|
||
$this->now = $this->now->modify($modifier); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that I didn't update this 🤦
Silly me...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor helper that simplifies FrozenClock usage during test setup, allowing to modify the clock based on a given modifier.
Benefit: