Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and security margin #115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mikelodder7
Copy link

This updates the dependencies to secure versions since crypto_box 0.6 has a vulnerability.
This also updates from using Chacha12 to Chacha20 which has higher security margins and performance difference is negligible.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.78% ⚠️

Comparison is base (57fe97c) 81.81% compared to head (edf11c1) 81.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   81.81%   81.03%   -0.78%     
==========================================
  Files          43       44       +1     
  Lines        2540     2573      +33     
==========================================
+ Hits         2078     2085       +7     
- Misses        462      488      +26     
Files Changed Coverage Δ
...crypt-core/src/encrypt/plain_message_shared_key.rs 87.87% <ø> (ø)
...crypt-core/src/encrypt/plain_message_public_key.rs 97.72% <100.00%> (-0.06%) ⬇️
...ncrypt/plain_message_shared_key/shared_key_core.rs 100.00% <100.00%> (ø)
serde-encrypt-core/src/random.rs 100.00% <100.00%> (ø)
serde-encrypt-core/tests/test_util/random/mod.rs 80.00% <100.00%> (ø)
serde-encrypt/src/random.rs 90.00% <100.00%> (ø)
serde-encrypt/src/shared_key.rs 91.17% <100.00%> (+0.55%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utkarshgupta137
Copy link

@laysakura ping

1 similar comment
@jonasg-adv
Copy link

@laysakura ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants