Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoga version upgrade to 3.2.0 #268

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

CtrlJone
Copy link

@CtrlJone CtrlJone commented Dec 5, 2024

Upgrade yoga to v3.2.0

@CtrlJone CtrlJone changed the title yoga version upgrade to 3.2.0 Yoga version upgrade to 3.2.0 Dec 5, 2024
@CtrlJone
Copy link
Author

CtrlJone commented Dec 5, 2024

@lucdion pls check again, thank you

@@ -589,7 +589,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CtrlJone , why change the deployment target to 14.0? Is it required?

Copy link
Author

@CtrlJone CtrlJone Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucdion , This is not necessary, but I noticed that you changed the version dependency to 14.0 in this commit!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions on version issues?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh true, my bad, I forgot that change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi,@lucdion ,What should I do next? Can you give me some suggestions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh true, my bad, I forgot that change

Any suggestions on version issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants