Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Logo enlarges on return to the home page. #355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −2
Open

fix: Logo enlarges on return to the home page. #355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a3faa8
fix: Logo enlarges on return to the home page.
abbi4code Aug 26, 2024
a3cf093
Updated the id attribute to 'navbar-brand-logo'
abbi4code Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion layouts/partials/image-modal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@
var imgTags = document.querySelectorAll("img");
imgTags.forEach(function (img) {
img.onclick = function () {
openModal(img);
if(img.id !== "navbar-brand_logo") {
openModal(img);
}
};
});
});
Expand Down
2 changes: 1 addition & 1 deletion layouts/partials/navbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<a class="navbar-brand" href="/">
<span class="navbar-brand__logo navbar-logo">
{{ $svg := resources.Get "icons/logo.svg" }}
<img class="footer-logo" src="{{ $svg.Permalink }}" alt="logo" />
<img class="footer-logo" id="navbar-brand_logo" src="{{ $svg.Permalink }}" alt="logo" />
Copy link

@Aviral0702 Aviral0702 Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename id to be id = "navbar-brand-logo" to maintain consistency.
LGTM!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've made the changes to rename the id to navbar-brand-logo for consistency.

</span>
<span class="navbar-brand__name"></span
></a>
Expand Down
Loading