Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #1182

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Cleanup #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ab9c9a
Fix video info table being rounded
ScrubN Aug 6, 2024
11d0477
Adjust wording of CLI deprecated argument warnings
ScrubN Aug 6, 2024
f1aebc1
Update editorconfig
ScrubN Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ resharper_csharp_wrap_before_binary_opsign = true
resharper_formatter_off_tag = @formatter:off
resharper_formatter_on_tag = @formatter:on
resharper_formatter_tags_enabled = true
resharper_indent_preprocessor_region = no_indent
resharper_place_accessorholder_attribute_on_same_line = false
resharper_place_field_attribute_on_same_line = false
resharper_place_simple_anonymousmethod_on_single_line = false
resharper_trailing_comma_in_multiline_lists = true
Expand Down
1 change: 0 additions & 1 deletion TwitchDownloaderCLI/Modes/InfoHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ private static void HandleVodTable(GqlVideoResponse videoInfo, GqlVideoChapterRe
var infoTableTitle = new TableTitle("Video Info");
var infoTable = new Table()
.Title(infoTableTitle)
.RoundedBorder()
.AddColumn(new TableColumn("Key"))
.AddColumn(new TableColumn("Value"))
.AddRow(new Markup("Streamer"), GetUserNameMarkup(infoVideo.owner.displayName, infoVideo.owner.login, DEFAULT_STRING))
Expand Down
10 changes: 5 additions & 5 deletions TwitchDownloaderCLI/Tools/PreParseArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,23 @@ private static string[] ConvertFromOldSyntax(string[] args, string processFileNa
switch (processedArgs[i])
{
case "--embed-emotes":
Console.WriteLine("[INFO] The program has switched from --embed-emotes to -E / --embed-images, consider using those instead. Run \'{0} help\' for more information.", processFileName);
Console.WriteLine("[WARNING] --embed-emotes has been deprecated in favor of -E / --embed-images and may be removed. Run '{0} help' for more information.", processFileName);
ConvertEmbedEmoteSyntax(processedArgs, i);
break;
case "-m" or "--mode":
Console.WriteLine("[INFO] The program has switched from --mode <mode> to verbs (like \'git <verb>\'), consider using verbs instead. Run \'{0} help\' for more information.", processFileName);
Console.WriteLine("[WARNING] --mode <mode> has been deprecated in favor of verbs (like 'git <verb>') and may be removed. Run '{0} help' for more information.", processFileName);
ConvertModeSyntax(processedArgs, i);
break;
case "--silent":
Console.WriteLine("[INFO] The program has switched from --silent to log levels, consider using log levels instead. '--log-level None' will be applied to the current session. Run \'{0} help\' for more information.", processFileName);
Console.WriteLine("[WARNING] --silent has been deprecated in favor of log levels. '--log-level None' will be applied to the current session and may be removed. Run '{0} help' for more information.", processFileName);
ConvertSilentSyntax(processedArgs, i);
break;
case "--verbose-ffmpeg":
Console.WriteLine("[INFO] The program has switched from --verbose-ffmpeg to log levels, consider using log levels instead. '--log-level Status,Info,Warning,Error,Ffmpeg' will be applied to the current session. Run \'{0} help\' for more information.", processFileName);
Console.WriteLine("[WARNING] --verbose-ffmpeg has been deprecated in favor of log levels and may be removed. '--log-level Status,Info,Warning,Error,Ffmpeg' will be applied to the current session. Run '{0} help' for more information.", processFileName);
ConvertVerboseFfmpegSyntax(processedArgs, i);
break;
case "--chat-connections":
Console.WriteLine("[INFO] The program has switched from --chat-connections to -t / --threads, consider using those instead. Run \'{0} help\' for more information.", processFileName);
Console.WriteLine("[WARNING] --chat-connections has been deprecated in favor of -t / --threads and may be removed. Run '{0} help' for more information.", processFileName);
ConvertChatConnectionsSyntax(processedArgs, i);
break;
}
Expand Down