Skip to content

Commit

Permalink
Addresses Issue #18 'Unknown provider' error. the gravatarImageServic…
Browse files Browse the repository at this point in the history
…e was missing the minification array causing the service to not instantiate properly.
  • Loading branch information
lavinjj committed Mar 6, 2014
1 parent fa5fcc9 commit d7cf806
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 12 deletions.
10 changes: 6 additions & 4 deletions ReadMe.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,15 @@ For more information about the Gravatar Image request check out their [Developer

## Change Log

### 1.3.1 - Addresses Issue #17 Hide the image, when loading fails. Now the image element will be removed from the DOM if the image fails to load.
### v1.3.2 - Addresses Issue #18 'Unknown provider' error. the gravatarImageService was missing the minification array causing the service to not instantiate properly.

### 1.3.0 - Restructured library structure to take advantage of angularjs-library yeoman generator to generate a single file for use.
### v1.3.1 - Addresses Issue #17 Hide the image, when loading fails. Now the image element will be removed from the DOM if the image fails to load.

### 1.2.0 - Added pull request to move imageSrc to a service for use by external consumers.
### v1.3.0 - Restructured library structure to take advantage of angularjs-library yeoman generator to generate a single file for use.

### 1.1.0 - Added additional namespaces to all attributes to keep from interfering with other AngularJS Library Directives. Resolves Issue #13
### v1.2.0 - Added pull request to move imageSrc to a service for use by external consumers.

### v1.1.0 - Added additional namespaces to all attributes to keep from interfering with other AngularJS Library Directives. Resolves Issue #13

## LICENSE

Expand Down
2 changes: 1 addition & 1 deletion app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ <h2>Gravatar Directive Example</h2>
<script src="components/bootstrap.css/js/bootstrap.js"></script>
<script src="components/angular/angular.js"></script>
<script src="app/app.js"></script>
<script src="../dist/angularjs-gravatardirective.js"></script>
<script src="../dist/angularjs-gravatardirective.min.js"></script>
</body>
</html>
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angularjs-gravatardirective",
"version": "1.3.1",
"version": "1.3.2",
"dependencies": {
"angular": "~1.2.12"
},
Expand Down
4 changes: 2 additions & 2 deletions dist/angularjs-gravatardirective.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ angular.module('angularjs-gravatardirective.directives')
}};
}]);
angular.module('angularjs-gravatardirective.services')
.factory('gravatarImageService', function (md5) {
.factory('gravatarImageService', ['md5', function (md5) {
return {
getImageSrc: function (value, size, rating, defaultUrl, secure) {
// convert the value to lower case and then to a md5 hash
Expand All @@ -75,7 +75,7 @@ angular.module('angularjs-gravatardirective.services')
return src;
}
};
});
}]);
// http://kevin.vanzonneveld.net
// + original by: Webtoolkit.info (http://www.webtoolkit.info/)
// + namespaced by: Michael White (http://getsprink.com)
Expand Down
2 changes: 1 addition & 1 deletion dist/angularjs-gravatardirective.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "angularjs-gravatardirective",
"description": "AngularJS Directive that takes an email address and creates an image tag to pull an avatar image form the Gravatar web site",
"version": "1.3.1",
"version": "1.3.2",
"homepage": "",
"keywords": ["angularjs", "gravatar", "directive"],
"repository": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
angular.module('angularjs-gravatardirective.services')
.factory('gravatarImageService', function (md5) {
.factory('gravatarImageService', ['md5', function (md5) {
return {
getImageSrc: function (value, size, rating, defaultUrl, secure) {
// convert the value to lower case and then to a md5 hash
Expand All @@ -11,4 +11,4 @@ angular.module('angularjs-gravatardirective.services')
return src;
}
};
});
}]);

0 comments on commit d7cf806

Please sign in to comment.