Resolve conflitcs and update pv #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Undistort pitch/yaw * Actually implement lol * Update TargetCalculations.java * fix yawpitch test units * format --------- Co-authored-by: amquake <[email protected]>
Add charuco calibration to photonvision. Currently does not support generating custom charuco boards. This does not support https://calib.io/pages/camera-calibration-pattern-generator. Currently only supports the 4X4_50 family. Also removes all dotboard calibration. Fixes using the lowest possible fps while doing calibration (now uses the highest fps available for each resolution).
* Implement class id/conf in photonlib * Maybe fix things * run lint * Update Packet.java comments * Update Packet.java comments again * Update comments * oops * Update packet.py --------- Co-authored-by: Chris Gerth <[email protected]>
…otonCamera error print (PhotonVision#1298) Previously reported itself which was confusing. New print: ``` Error at org.photonvision.PhotonCamera.verifyVersion(PhotonCamera.java:378): Found the following PhotonVision cameras active on NetworkTables: ==> HD_Pro_Webcam_C920 ==> Arducam_OV9281_USB_Camera ```
Disables Arm32 builds and removes mention of the build option in the README.
…n checking (PhotonVision#1323) * change verifyversion to use member variable * Revert "change verifyversion to use member variable" This reverts commit 4439839. * Removed inline specifier for versioncheck variable --------- Co-authored-by: Drew Williams <[email protected]>
This was supposed to speed up incremental compilation, but not sure it actually does. It's better form tm tho and fixes a robotpy-wrapper weirdness
Also bumps to new builds of artifacts (NFC)
We previously assumed only OpenCV5 but mrcal uses opencv8
Change default AprilTag family to 36h11 Resolves PhotonVision#1226
* Update build.yml
* Fix no stream on camera unplug. * Spotless remove datarate * Make Static Frames Class * lint and format
…urces zip (PhotonVision#1335) Combined sources zip is useful for robotpy to build both targeting & lib in the same build
* Create combine job * Update build.yml * Bump max workers in photonlib * Oops * actually kill entirely * Maybe fix test * Don't run tests * Update OpenCVTest.java * Update build.yml * Use upload-artifact@v4 * Update build.yml * Update build.yml
* Update build.gradle
…#1334)" (PhotonVision#1351) This reverts commit 6ff7b3e. See PhotonVision#1351 for context
temp fix for this issue with csi cameras
Add support for the old opencv charuco board like calibio. Add support for other tag families while calibrating. Fix calibration issue index out of range with charuco missing points.
…1356) Windows users will have to add `"-Dorg.gradle.java.home=C:\Users\Public\wpilib\2024\jdk"` to gradle invocations, ie `./gradlew run "-Dorg.gradle.java.home=C:\Users\Public\wpilib\2024\jdk"`, due to MSVC ABI breakages and other stupidity
The OV9782 camera has a specific exposure range, so a camera quirk for it needs to exist. The default white balance is also pretty bad, so it must be adjusted. Closes PhotonVision#1204 --------- Co-authored-by: Matt <[email protected]> Co-authored-by: Cameron (3539) <[email protected]>
There were a couple of typos in the last OV9782 fix, this addresses those. Additionally, remove Matt's comment that he forgot.
Pnpm is like npm except instead of keeping multiple copies of dependencies, it shares a single copy for multiple dependencies significantly reducing build time and the space needed to hold all the dependencies. Read [here](https://pnpm.io/motivation) for more info. This changes our CI to use pnpm and allows developers to choose to use pnpm instead of npm. Also, pnpm has a built-in node version manager so devs no longer need to use nvm to work on photonvision. All npm functionality (including photon-server gradle tasks) still functions using npm so this isn't breaking. We should make a docs change to suggest to use pnpm.
Reverts PhotonVision#1375 Causes white screen UI Bug, "the way we currently strap everything with vue2 and vuetify has a lot of footguns in it, and using a newer package manager where each subdependency gets its own version of node is causing incorrect dependency resolution which also means we can't fix this without either updating node or patching those dependencies id say just revert the PR for now until I or someone else can do the vue3 update"
This removes the extra GetLastChange call to keep everything properly atomic. Closes PhotonVision#1303
This updates the install script to work correctly on Ubuntu 24.04 versions of the Orange Pi 5 images. Changes include: - installing libatomic1 - disabling networkd-wait-online if using Network Manager - using systemctl instead of service to detect if photonvision is running - detecting if this is a RK3588 cpu and enabling all cores
Uses logic in PhotonVision/photon-libcamera-gl-driver#16 to push the ov9281 down to its true minimum exposure. Updates UI to list the exposure settings in ~~microseconds.~~ Native units - not everyone works in microseconds. Does its darndest to actually try to set the exposure in ~~microseconds.~~ Native Units. To do this... Lifecam is funky when doing this - [cscore limits the exposure settings to certain quantized values](https://github.com/wpilibsuite/allwpilib/blob/main/cscore/src/main/native/linux/UsbCameraImpl.cpp#L129). Add a new camera quirk to allow that. ~~Updated camera quirks to re-evaluate every camera load (rather than recalling from settings - this shouldn't be necessary)~~ This should be rolled back, needed for arducam type selection. Updated camera quirk matching logic to make PID/VID optional, and basename optional (and only match trailing characters). This enables mirroring CSCore's logic for identifying lifecams by name. Updated the USBCamera to primarily use cscore's exposed property names. Since camera manufacturers use a potpourri of names for the same thing.... For nice-to-have settings: new soft-set logic to try all possible names, but gracefully pass if the property isn't there. For required settings: Search a list for the first setting that's supported, fail if none are supported. More logging of camera properties to help debug. Note: most of this work is because cscore doesn't directly expose a massaged exposure-setting-absolute API (and, given what we've seen, probably _shouldn't_, this struggle is not for the faint of heart). --------- Co-authored-by: Matt <[email protected]>
This reverts commit f3faf80.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.