[Client] Fix issue with clearing multitag buffer (PhotonVision#1299)

* fix improper state reference * add parentheses for clarity * fix buffer array reactivity + loop optimization
laviRZ · Mar 23, 2024 · 0106880 · 0106880
1 parent 2d8b1ec
commit 0106880
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/photon-client/src/components/dashboard/tabs/TargetsTab.vue b/photon-client/src/components/dashboard/tabs/TargetsTab.vue
@@ -28,7 +28,7 @@ const calculateStdDev = (values: number[]): number => {
 };
 const resetCurrentBuffer = () => {
   // Need to clear the array in place
-  while (useStateStore().currentMultitagBuffer?.length != 0) useStateStore().currentMultitagBuffer?.pop();
+  if (useStateStore().currentMultitagBuffer) useStateStore().currentMultitagBuffer!.length = 0;
 };
 </script>
 

diff --git a/photon-client/src/stores/StateStore.ts b/photon-client/src/stores/StateStore.ts
@@ -84,7 +84,8 @@ export const useStateStore = defineStore("state", {
       return this.backendResults[this.currentCameraIndex.toString()];
     },
     currentMultitagBuffer(): MultitagResult[] | undefined {
-      return this.multitagResultBuffer[this.currentCameraIndex.toString()];
+      if (!this.multitagResultBuffer[this.currentCameraIndex]) this.multitagResultBuffer[this.currentCameraIndex] = [];
+      return this.multitagResultBuffer[this.currentCameraIndex];
     }
   },
   actions: {