feat(modules): standalone erc20 with external store #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holic
reviewed
Aug 30, 2024
| import { RESOURCE_TABLE } from "@latticexyz/store/src/storeResourceTypes.sol"; | ||
| import { ResourceId, ResourceIdLib } from "@latticexyz/store/src/ResourceId.sol"; | ||
|
|
||
| import { Store } from "../src/Store.sol"; |
There was a problem hiding this comment.
there's a StoreMock you could use from the store package that does this (but we'd need to make sure its exported in the npm package, like MudTest in world package)
There was a problem hiding this comment.
The StoreMock was missing several functions that are needed when using Store without a World, like getStaticField() and getDynamicField()
There was a problem hiding this comment.
doesn't look like we're using those methods anymore?
either way, would be good to add those to the mock
…0-external-store
…yz/mud into tr/erc20-external-store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.