vfio: avoid possible overflow in vfio_iommu_type1_pin_pages

add parentheses to avoid possible vaddr overflow. Fixes: a54eb55 ("vfio iommu type1: Add support for mediated devices") Signed-off-by: Yan Zhao <[email protected]> Signed-off-by: Alex Williamson <[email protected]>
lategoodbye · Apr 20, 2020 · 0ea971f · 0ea971f
1 parent 205323b
commit 0ea971f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
@@ -555,7 +555,7 @@ static int vfio_iommu_type1_pin_pages(void *iommu_data,
 			continue;
 		}
 
-		remote_vaddr = dma->vaddr + iova - dma->iova;
+		remote_vaddr = dma->vaddr + (iova - dma->iova);
 		ret = vfio_pin_page_external(dma, remote_vaddr, &phys_pfn[i],
 					     do_accounting);
 		if (ret)