Read saveset name from the right place #168
Conversation
Support DUMPER format 6, which has saveset name at different offset. Also check dumper tape format and reject too old or invalid format codes.
|
|
||
| read_asciz (name, &data[3]); | ||
| // Check tape format! Otherwise breaks e.g. on Install tapes (which aren't in dumper format). | ||
| if ((data[0] < 4) || (data[0] > 6)) { |
There was a problem hiding this comment.
Will this work with TENEX' MINI-DUMPER?
| read_asciz (name, &data[3]); | ||
| // Check tape format! Otherwise breaks e.g. on Install tapes (which aren't in dumper format). | ||
| if ((data[0] < 4) || (data[0] > 6)) { | ||
| // Formats older than 4 not supported, and 6 was the highest (TOPS-20 v6-7). |
There was a problem hiding this comment.
Formats 1-3 would be supported if I knew how. Format 0 is MINI-DUMPER.
|
Format 0 has a different header, as far as I can tell. See TOPS-20 v4 DUMPER for some ways of handling it (there it is called TENEX/BBN format). Here, you should probably do the same check as at SETHDR there, to see if it is ASCII directly in the format field (rather than a format code). But I guess there are more differences - does dumper.c handle TENEX dumper files as it is now? Can you point at some tape file in that format? |
|
My main purpose for writing this dumper.c was to create TENEX mini-dumper files. I don't have any tape samples from a real TENEX system. I have been testing the output from my program against MINI-DUMPER running on TENEX, and it seemed to work. You could of course create some tape files with dumper.c but I can't guarantee they are 100% correct. |
Support DUMPER format 6, which has saveset name at different offset. Also check dumper tape format and reject too old or invalid format codes.
This lets this program display the right saveset name for more tapes e.g. in http://www.bitsavers.org/bits/DEC/pdp10/magtape/dec_distribs/TOPS-20/.