Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: adds support for symbol change #26

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avion23
Copy link

@avion23 avion23 commented Sep 18, 2022

This is my proposal for symbol changes.

Test data attached.

symbol-change.csv

It would be nice to also check if the replacement symbol is the correct one, but I think that's not possible with the current structure.

Does this work? Is there a better approach?

@avion23 avion23 changed the title adds support for symbol change draft: adds support for symbol change Sep 23, 2022
@avion23
Copy link
Author

avion23 commented Sep 23, 2022

symbol-change-mock.csv
I've tested with symbol-change-mock.csv. That's the same data, but the symbol change was removed.
This results in

Stillhalter-Gewinne                     109.85  109.85
Stillhalter-Verluste                    -67.43  -67.43
Stillhalter Gesamt                       42.42   42.42

while the original csv file shows

Stillhalter-Gewinne                     222.43  222.43
Stillhalter-Verluste                   -180.01 -180.01
Stillhalter Gesamt                       42.42   42.42

This implies the trades are recorded twice during the symbol change which is wrong.

@avion23 avion23 marked this pull request as draft September 23, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant