Fix for directories with spaces (#147)

laravel · Sep 8, 2020 · ef8e322 · ef8e322
1 parent e860aad
commit ef8e322
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/NewCommand.php b/src/NewCommand.php
@@ -84,15 +84,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
             if (PHP_OS_FAMILY == 'Windows') {
                 array_unshift($commands, "rd /s /q \"$directory\"");
             } else {
-                array_unshift($commands, "rm -rf $directory");
+                array_unshift($commands, "rm -rf \"$directory\"");
             }
         }
 
         if (PHP_OS_FAMILY != 'Windows') {
-            $commands[] = "chmod 644 $directory/artisan";
+            $commands[] = "chmod 644 \"$directory/artisan\"";
         }
 
-        if ($this->runCommands($commands, $input, $output)->isSuccessful()) {
+        if (($process = $this->runCommands($commands, $input, $output))->isSuccessful()) {
             if ($name && $name !== '.') {
                 $this->replaceInFile(
                     'APP_URL=http://localhost',
@@ -114,7 +114,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $output->writeln(PHP_EOL.'<comment>Application ready! Build something amazing.</comment>');
         }
 
-        return 0;
+        return $process->getExitCode();
     }
 
     /**

diff --git a/tests/NewCommandTest.php b/tests/NewCommandTest.php
@@ -18,7 +18,7 @@ public function test_it_can_scaffold_a_new_laravel_app()
             if (PHP_OS_FAMILY == 'Windows') {
                 exec("rd /s /q \"$scaffoldDirectory\"");
             } else {
-                exec("rm -rf $scaffoldDirectory");
+                exec("rm -rf \"$scaffoldDirectory\"");
             }
         }