Skip to content

Commit

Permalink
remove question... suggest npm build
Browse files Browse the repository at this point in the history
  • Loading branch information
taylorotwell committed Oct 10, 2024
1 parent b5de771 commit 667c610
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/NewCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,9 @@ protected function interact(InputInterface $input, OutputInterface $output)
) === 'Pest');
}

if (! $input->getOption('git') && $input->getOption('github') === false && Process::fromShellCommandline('git --version')->run() === 0) {
$input->setOption('git', confirm(label: 'Would you like to initialize a Git repository?', default: false));
}
// if (! $input->getOption('git') && $input->getOption('github') === false && Process::fromShellCommandline('git --version')->run() === 0) {
// $input->setOption('git', confirm(label: 'Would you like to initialize a Git repository?', default: false));
// }
}

/**
Expand Down Expand Up @@ -243,6 +243,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int

$output->writeln(" <bg=blue;fg=white> INFO </> Application ready in <options=bold>[{$name}]</>. You can start your local development using:".PHP_EOL);
$output->writeln('<fg=gray>➜</> <options=bold>cd '.$name.'</>');
$output->writeln('<fg=gray>➜</> <options=bold>npm install && npm run build</>');

if ($this->isParked($directory)) {
$url = $this->generateAppUrl($name);
Expand Down

2 comments on commit 667c610

@Jubeki
Copy link
Contributor

@Jubeki Jubeki commented on 667c610 Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @taylorotwell and @crynobone is there a reason the git init question was removed? I liked it a lot, that this question was asked.

@RobertBoes
Copy link

@RobertBoes RobertBoes commented on 667c610 Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Jubeki here, it was quite a useful option. What's the reason for leaving it in as a comment if it's removed? And kind of a bummer this isn't done through PRs, rather confusing to see the question suddenly being gone, without any mention in the changelog.

Please sign in to comment.