[7.x] Fix 'loadCount' method to ensure count is set on all models #32740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a model is present multiple times in a collection, all models should get the relationship count set, instead of only the first occurence of that model in the collection.
I discovered this bug while I was creating PR #32739 that adds
loadMorphCount
method. That method uses theloadCount
method. The temporary collection that calls theloadCount
method, can contain duplicates (e.g. 2 comments can morph to the same post)