Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add documentation #2

wants to merge 1 commit into from

Conversation

gilice
Copy link

@gilice gilice commented Dec 11, 2022

No description provided.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@maxpetts
Copy link

LGTM 👍

Added a few suggestions to circumvent a few issues I ran into following this guide, but I've now got the plugin loading into Lapce. Thanks for taking the time to add.

@panekj what do you think?

Co-authored-by: Max Petts <[email protected]>
Signed-off-by: gilice <[email protected]>
@gilice
Copy link
Author

gilice commented Dec 21, 2022

thank you @maxpetts . I updated the branch with your changes included, too.

@panekj
Copy link
Collaborator

panekj commented Dec 21, 2022

I'm not interested in maintaining documentation of the template as most of the things presented in this PR will be explained in Lapce documentation once the plugin API stabilises, or it goes over the board of explaining what each thing is/does.
I won't mind a short description/reference list of required toolset to develop plugins (cargo, cargo-make, wasm-wasi32 toolchain) based on this repository.

@maxpetts
Copy link

I'm not interested in maintaining documentation of the template as most of the things presented in this PR will be explained in Lapce documentation once the plugin API stabilises, or it goes over the board of explaining what each thing is/does. I won't mind a short description/reference list of required toolset to develop plugins (cargo, cargo-make, wasm-wasi32 toolchain).

Ok that's understandable if the plugin API is subject to change. Perhaps we should omit the majority of the readme to just be:

  • Installing prerequisites (rust/cargo, cargo make, wasm-wasi32 target)
  • Running project (cargo make dev)

However, I believe the plugin folder structure should be documented, as this necessary to actually get Lapce to use the plugin - we could include a working as of 21/12/22 tag; just to avoid the future maintenance requirement by yourself?

@panekj
Copy link
Collaborator

panekj commented Dec 27, 2022

we could include a working as of 21/12/22 tag; just to avoid the future maintenance requirement by yourself?

That still puts burden of maintenance on me

However, I believe the plugin folder structure should be documented, as this necessary to actually get Lapce to use the plugin

I believe it shouldn't as there is nothing to document? Plugins (and not only) directory paths should not be relied on and it should be opened via Lapce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants