Change DifferentialEquations dependence to OrdinaryDiffEq, Fix simulate_de crashes #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I fix many of the lingering issues that have been around as a result of the implementation with DifferentialEquations.jl.
First, I have changed to using only OrdinaryDiffEq.jl. This is a reasonably major change, so I will tag a new version (0.3.0) when this is merged into main.
I have also fixed the crashing issues that were causing the build to fail. The issue arose from not specifying an algorithm in DiffEq.jl (now using Tsit5()), causing it to default to an algorithm that could not handle complex values. I am creating an issue on DiffEq.jl and will link it later. This issue has caused me to update one of the test cases to increase the precision required by Tsit5() for the same amount of precision. I have also removed all lower bound tests in the test instances so that our build doesn't fail every time a precision effecting change is incorporated in DiffEq.jl. We still have the lower bound tests to allow us to know if something breaks the performance aggregiously.