Remove constraint_power_magnitude_sqr_on_off(pm::_PM.AbstractQCWRModel ...)
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbybp
approved these changes
Oct 30, 2024
Robbybp
reviewed
Oct 31, 2024
Comment on lines
-140
to
-144
| if isinteger(z) | ||
| z_lb = z_ub = z | ||
| else | ||
| z_lb, z_ub = InfrastructureModels.variable_domain(z) | ||
| end |
There was a problem hiding this comment.
Just noting here, while I remember, that this "if block" is the main difference between this and the PowerModels implementation. If this function is necessary for anything, we should (a) document the purpose of this change and (b) find a way to implement it without redefining the PowerModels method.
There was a problem hiding this comment.
This goes back 5 years, but if I remember right, the intent is that only damaged lines have a binary variable. Non-damaged lines have the non-switching power flow constraints, while damaged lines have the switching power flow constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73