Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the request URL construction in playground #622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jianzs
Copy link

@jianzs jianzs commented Apr 26, 2024

Previously, the playground was building request URLs by removing the playground suffix and appending stream_log. This worked when the URL ended with playground, but failed for URLs ending with index.html. The issue was the code only checked for URLs ending with playground and did not account for index.html endings.

Previously, the playground was building request URLs by removing the `playground` suffix and appending `stream_log`. This worked when the URL ended with `playground`, but failed for URLs ending with `index.html`. The issue was the code only checked for URLs ending with `playground` and did not account for `index.html` endings.
Copy link

cla-bot bot commented Apr 26, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the username @jianzs on file. In order for us to review and merge your code, please complete the Individual Contributor License Agreement here https://forms.gle/AQFbtkWRoHXUgipM6 .

This process is done manually on our side, so after signing the form one of the maintainers will add you to the contributors list.

For more details about why we have a CLA and other contribution guidelines please see: https://github.com/langchain-ai/langserve/blob/main/CONTRIBUTING.md.

@eyurtsev eyurtsev self-assigned this Apr 26, 2024
@eyurtsev
Copy link
Collaborator

@jianzs thank you, I'll review and release next week

@jianzs
Copy link
Author

jianzs commented May 6, 2024

@eyurtsev Hi there! I was wondering if you might have some time to review the PR I submitted? Please feel free to point out any issues or concerns at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants