Website fixes post 1.3.1 and 1.2.3 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 7, 2017 15:20
Also inserts the current stable Lagom release rather than linking to the documentation index.
Also inserts the current stable Lagom release rather than linking to the documentation index.
ignasi35
reviewed
Mar 7, 2017
| <li> | ||
| <code>package</code> — defaults to the same value as the <code>groupId</code> | ||
| </li> | ||
| </ul> |
There was a problem hiding this comment.
There was a problem hiding this comment.
I wouldn't do anything in this PR. Just added the comment to x-ref from #32
ignasi35
reviewed
Mar 7, 2017
| <div class="small-12 columns"> | ||
| (If you aren’t using one of these tools already, see this information to | ||
| help you choose between <a href="http://www.scala-sbt.org/0.13/docs/index.html">sbt</a> and | ||
| <a href="https://maven.apache.org">Maven</a>.) The Lagom development environment runs on |
There was a problem hiding this comment.
Should the . be outside the parens in the sinppet
<a href="https://maven.apache.org">Maven</a>.)
```
??
PS: I read the comments wrt UK/US/AUS variants and can't remember if this was discussed there. Feel free to ignore.
There was a problem hiding this comment.
I think when the complete sentence is parenthesized, the period goes inside.
ignasi35
approved these changes
Mar 7, 2017
rstento
suggested changes
Mar 7, 2017
|
Sorry, @rstento but I'm not sure which part you're referring to. Could you comment on the specific line? I did test everything to make sure that the text matched up with what was happening, but maybe I missed something. |
rstento
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be easier to review commit-by-commit: I did a lot of reformatting, but I did all of the reformatting in separate commits from the other substantive changes.