Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid padding of list item in certain situations. #32

Open
ignasi35 opened this issue Feb 22, 2017 · 1 comment
Open

Invalid padding of list item in certain situations. #32

ignasi35 opened this issue Feb 22, 2017 · 1 comment
Labels
help wanted Ready and waiting for a volunteer status:backlog

Comments

@ignasi35
Copy link
Contributor

As mentioned in https://github.com/lagom/lagom/pull/516/files#r102375824 there's certain situations in which list items will use the wrong padding.

I tried to nail down the issue but the rules to generate the HTML seem a bit more complex than I anticipated. I used the markdown:

After working through "Getting started with Lagom", follow the path that make the most sense to you:

* single item list (uses smaller font, padding underneath comes from ul-tag):

A separator paragraph, lorem ipsum. Lorem ipsum dolor sit amet, consectetur adipiscing elit.

* single item list with nested list (uses smaller font and no padding:
    * asdf
    * asdf
    * asdf

A separator paragraph, lorem ipsum. Lorem ipsum dolor sit amet, consectetur adipiscing elit. 

* first item of a list with nested list (uses bigger font and padding, ¿both from p-tag?):
    * [[Import an existing Maven project into Eclipse|EclipseMavenInt]]
    * [[Create a new Eclipse project using the Lagom Maven archetype|EclipseMavenNew]]
    * [[Import an existing sbt build into Eclipse|EclipseSbt]]

* second item of a list with nested list (uses bigger font and padding, ¿both from p-tag?):
    * [[Import an existing Maven project into Intellij|intellijMaven]]
    * [[Import an existing sbt build into Intellij|IntellijSbtJava]]

* last item of a list (uses bigger font, why?)

Which creates the page:

screen shot 2017-02-22 at 14 24 19

@ignasi35
Copy link
Contributor Author

ignasi35 commented Mar 7, 2017

See also https://github.com/lagom/lagom.github.io/pull/44/files#r104664780

Review lists in Getting Started (java-mvn, java-sbt and scala)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Ready and waiting for a volunteer status:backlog
Development

No branches or pull requests

3 participants