Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CAO model loading to avoid "Exception: basic_ios::clear: iostream error" #1529

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

s-trinh
Copy link
Contributor

@s-trinh s-trinh commented Dec 22, 2024

lagadic/visp-images#26

Avoid exception when loading a CAO model with no new line at the end of the file:

Cannot get the number of circles. Defaulting to zero.
Exception: basic_ios::clear: iostream error

Remove pointers usage and add some sanity checks.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.84%. Comparing base (bc9a67e) to head (d195822).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
modules/tracker/mbt/src/vpMbTracker.cpp 83.78% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
+ Coverage   53.82%   53.84%   +0.01%     
==========================================
  Files         441      441              
  Lines       53859    53854       -5     
==========================================
+ Hits        28991    28995       +4     
+ Misses      24868    24859       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Avoid exception "Exception: basic_ios::clear: iostream error" when loading a CAO model without new line at the end of the file.
Add sanity checks when loading CAO models.
@s-trinh s-trinh force-pushed the add_MBT_cao_model_sanity_checks branch from 4bce648 to d195822 Compare December 22, 2024 20:59
@fspindle fspindle merged commit 03c0fb1 into lagadic:master Dec 30, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants