Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: client v2 #24

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feature: client v2 #24

wants to merge 4 commits into from

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Dec 12, 2023

refs lablup/backend.ai#1772, lablup/backend.ai#1784

Implement client_v2

  • Let any data including key and value serialized(and deserialized) from the client side.
  • Disallow *-prefix requests since they need string typed key. Instead, you can use *-range requests.
  • Does not use EtcdRequestGenerator because there is no complicated request building logic anymore such as parsing range_end to support -prefix functionalities.

@fregataa fregataa added the feature New feature or request label Dec 12, 2023
@fregataa fregataa self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 316 lines in your changes are missing coverage. Please review.

Comparison is base (5b512ef) 53.00% compared to head (ae98864) 47.04%.

Files Patch % Lines
src/etcetra/v2/client.py 0.00% 309 Missing ⚠️
src/etcetra/v2/types.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   53.00%   47.04%   -5.96%     
==========================================
  Files          37       39       +2     
  Lines        2496     2812     +316     
==========================================
  Hits         1323     1323              
- Misses       1173     1489     +316     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fregataa fregataa requested a review from achimnol December 13, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant