fix: Broken session CLI commands due to invalid initialization of ComputeSession
#3222
+93
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:client
jopemachine
changed the title
session rename commandrename, commit command
jopemachine
changed the title
rename, commit commandrename, commit command
jopemachine
changed the title
rename, commit commandComputeSession
jopemachine
force-pushed
the
fix/broken-session-rename-command
branch
from
dd8e2c3 to
8d8e412
Compare
jopemachine
commented
Dec 27, 2024
Comment on lines
-1268
to
-1272
| try: | ||
| session_id = uuid.UUID(session_name_or_id) | ||
| compute_session = session.ComputeSession.from_session_id(session_id) | ||
| except ValueError: | ||
| compute_session = session.ComputeSession(session_name_or_id, owner_access_key) |
There was a problem hiding this comment.
The intention of the code appears to be to raise a ValueError if session_name_or_id is a str that is not a UUID, and to call from_session_id if it is a session ID. Otherwise, the default constructor is intended to be called.
However, when from_session_id is called, the name field is not populated, which causes the code to not function correctly.
Additionally, it seems to be a mistake that owner_access_key is not set when session_id is of UUID type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3202 (BA-19)
This PR fixes following broken session CLI commands.
session renamesession set-prioritysession eventssession commitAbout milestone (24.09)
Starting from version
24.09, the code usessession_id(UUID) as an argument to create aComputeSessionobject by callingfrom_session_id. However, this approach does not populate theComputeSession.namefield. As a result, it sends API calls like/session/None (session_id_or_name)/rename?name=new-name, leading to incorrect behavior.So this PR only needs to be backported to version
24.09.Checklist: (if applicable)