Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Broken session CLI commands due to invalid initialization of ComputeSession #3222

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

fix: Broken session CLI commands due to invalid initialization of ComputeSession #3222

wants to merge 13 commits into from
+68 −23

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Dec 8, 2024 •
edited
Loading

Fix #3202.

This PR fixes following broken session CLI commands.

  • session rename
  • session set-priority
  • session events
  • session commit

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation

@github-actions github-actions bot added comp:client Related to Client component comp:cli Related to CLI component size:XS ~10 LoC type:bug Reports about that are not working labels Dec 8, 2024
@github-actions github-actions bot added size:M 30~100 LoC and removed size:XS ~10 LoC labels Dec 27, 2024
@jopemachine jopemachine changed the title fix: Broken session rename command fix: Broken session rename, commit command Dec 27, 2024
@jopemachine jopemachine changed the title fix: Broken session rename, commit command fix: Broken session rename, commit command Dec 27, 2024
@jopemachine jopemachine added this to the 24.09 milestone Dec 27, 2024
@jopemachine jopemachine marked this pull request as ready for review December 27, 2024 02:47
@jopemachine jopemachine marked this pull request as draft December 27, 2024 02:52
@jopemachine jopemachine changed the title fix: Broken session rename, commit command fix: Broken session CLI commands due to invalid initialization of ComputeSession Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jopemachine jopemachine

Labels
comp:cli Related to CLI component comp:client Related to Client component size:M 30~100 LoC type:bug Reports about that are not working
Projects
None yet
Milestone
24.09
Development

Successfully merging this pull request may close these issues.

Session rename, commit, set-priority CLI commands not working due to invalid initialization
1 participant
@jopemachine