Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show vfolder types in folder create modal based on user permission #2992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Dec 27, 2024

This PR resolves #FR-240 issue

Apply rules based on the current user role and list_allowed_types to the vfolder type selector in FolderCreateModal.

Changes:

  • Only super admin or admin can create project type vfolder.
  • vfolder type in folder create modal is based on list_allowed_types comes from server
  • Show max_vfolder_count' in Project Resource Policy' if user role is only Super Admin' or Admin'.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:M 30~100 LoC label Dec 27, 2024
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 27, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.03% (-0% 🔻)
398/7919
🔴 Branches
4.36% (-0.02% 🔻)
237/5438
🔴 Functions
3.02% (-0% 🔻)
78/2585
🔴 Lines
4.94% (-0% 🔻)
383/7751

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 69c6c97

@ironAiken2 ironAiken2 requested a review from agatha197 December 27, 2024 04:27
@ironAiken2 ironAiken2 marked this pull request as ready for review December 27, 2024 04:27
@ironAiken2 ironAiken2 requested a review from lizable December 27, 2024 04:52
@ironAiken2 ironAiken2 force-pushed the fix/folder-types-based-on-user-permission branch from eba49ec to 69c6c97 Compare December 27, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant