Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR-1] fix: set Max Network Count field to project resource policy #2989

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Dec 24, 2024

This PR resolves #2988 issue.

Related PR: Core #2857

Fixes an issue where the addition of the max_network_count field to the Project resource policy prevented the creation of a new project resource policy due to the undefinedType input of that field.

Changes:

  • Since core version "24.12.0", max_network_count field was added to the proeject resource policy.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Dec 24, 2024
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 24, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.03% (-0% 🔻)
398/7910
🔴 Branches
4.37% (-0.01% 🔻)
237/5418
🔴 Functions
3.02% (-0% 🔻)
78/2584
🔴 Lines
4.95% (-0% 🔻)
383/7742

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 84ed0b5

@ironAiken2 ironAiken2 requested a review from yomybaby December 24, 2024 05:48
@ironAiken2 ironAiken2 marked this pull request as ready for review December 24, 2024 05:49
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check version compatibility. I got a error on 24.09.3 manager.

{
    "data": null,
    "errors": [
        {
            "message": "Variable '$props' got invalid value {'max_vfolder_count': 0, 'max_quota_scope_size': -1, 'max_network_count': -1}; Field 'max_network_count' is not defined by type 'CreateProjectResourcePolicyInput'. Did you mean 'max_vfolder_count'?",
            "locations": [
                {
                    "line": 1,
                    "column": 74
                }
            ]
        }
    ]
}

@ironAiken2 ironAiken2 force-pushed the fix/create-project-resource-policy branch from 9a113c2 to fc2d006 Compare December 24, 2024 10:04
@ironAiken2 ironAiken2 requested a review from yomybaby December 24, 2024 10:04
@lizable lizable self-requested a review December 26, 2024 01:23
@ironAiken2 ironAiken2 force-pushed the fix/create-project-resource-policy branch from fc2d006 to 4d1d9de Compare December 26, 2024 01:40
@github-actions github-actions bot added the area:lib Library and SDK related issue. label Dec 26, 2024
@ironAiken2 ironAiken2 requested a review from yomybaby December 26, 2024 01:55
@ironAiken2 ironAiken2 force-pushed the fix/create-project-resource-policy branch from 4d1d9de to 79c6dc3 Compare December 26, 2024 06:59
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ironAiken2 ironAiken2 removed the request for review from yomybaby December 26, 2024 07:22
Copy link

graphite-app bot commented Dec 26, 2024

Merge activity

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

### This PR resolves [#2988](#2988) issue.

Related PR: [Core #2857](lablup/backend.ai#2857)

Fixes an issue where the addition of the `max_network_count` field to the Project resource policy prevented the creation of a new project resource policy due to the undefinedType input of that field.

**Changes:**
- Since core version "24.12.0", `max_network_count` field was added to the proeject resource policy.

**Checklist:** (if applicable)

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@ironAiken2 ironAiken2 force-pushed the fix/create-project-resource-policy branch from d842db1 to 84ed0b5 Compare December 26, 2024 07:24
@graphite-app graphite-app bot merged commit 84ed0b5 into main Dec 26, 2024
6 checks passed
@graphite-app graphite-app bot deleted the fix/create-project-resource-policy branch December 26, 2024 07:25
@ironAiken2 ironAiken2 changed the title fix: set Max Network Count field to project resource policy [FR-1] fix: set Max Network Count field to project resource policy Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create Project Resource Policy
3 participants