-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR-1] fix: set Max Network Count
field to project resource policy
#2989
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.03% (-0% 🔻) |
398/7910 |
🔴 | Branches | 4.37% (-0.01% 🔻) |
237/5418 |
🔴 | Functions | 3.02% (-0% 🔻) |
78/2584 |
🔴 | Lines | 4.95% (-0% 🔻) |
383/7742 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 84ed0b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check version compatibility. I got a error on 24.09.3 manager.
{
"data": null,
"errors": [
{
"message": "Variable '$props' got invalid value {'max_vfolder_count': 0, 'max_quota_scope_size': -1, 'max_network_count': -1}; Field 'max_network_count' is not defined by type 'CreateProjectResourcePolicyInput'. Did you mean 'max_vfolder_count'?",
"locations": [
{
"line": 1,
"column": 74
}
]
}
]
}
9a113c2
to
fc2d006
Compare
fc2d006
to
4d1d9de
Compare
4d1d9de
to
79c6dc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merge activity
|
<!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> ### This PR resolves [#2988](#2988) issue. Related PR: [Core #2857](lablup/backend.ai#2857) Fixes an issue where the addition of the `max_network_count` field to the Project resource policy prevented the creation of a new project resource policy due to the undefinedType input of that field. **Changes:** - Since core version "24.12.0", `max_network_count` field was added to the proeject resource policy. **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
d842db1
to
84ed0b5
Compare
Max Network Count
field to project resource policyMax Network Count
field to project resource policy
This PR resolves #2988 issue.
Related PR: Core #2857
Fixes an issue where the addition of the
max_network_count
field to the Project resource policy prevented the creation of a new project resource policy due to the undefinedType input of that field.Changes:
max_network_count
field was added to the proeject resource policy.Checklist: (if applicable)