feat: add BAIPropertyFilter to Endpoint list #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
force-pushed
the
feat/endpoint-filter-pagination-deferred-value
branch
2 times, most recently
from
e492237 to
71bf153
Compare
yomybaby
force-pushed
the
feature/endpoint-baipropertyfilter
branch
from
9848ede to
0245f18
Compare
yomybaby
force-pushed
the
feat/endpoint-filter-pagination-deferred-value
branch
from
71bf153 to
4b3f594
Compare
yomybaby
force-pushed
the
feature/endpoint-baipropertyfilter
branch
from
0245f18 to
33d14c0
Compare
Base automatically changed from
feat/endpoint-filter-pagination-deferred-value
to
main
September 4, 2024 15:06
yomybaby
force-pushed
the
feature/endpoint-baipropertyfilter
branch
from
33d14c0 to
5c373bf
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.41% (-0.01% 🔻) |
348/6438 |
| 🔴 | Branches | 4.86% (-0.01% 🔻) |
218/4487 |
| 🔴 | Functions | 3.16% (-0% 🔻) |
67/2123 |
| 🔴 | Lines | 5.29% (-0.01% 🔻) |
333/6289 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 228ea96
yomybaby
force-pushed
the
feature/endpoint-baipropertyfilter
branch
from
5c373bf to
17dd74f
Compare
6 tasks
yomybaby
force-pushed
the
feature/endpoint-baipropertyfilter
branch
2 times, most recently
from
f4015cd to
5734dfd
Compare
Merge activity
|
### TL;DR Added advanced filtering capabilities to the Endpoint List Page. ### What changed? - Added support for filtering endpoints based on name, service endpoint, and owner (for admin/superadmin roles). - Implemented query parameter support for filters using `useQueryParam`. - Updated the layout to accommodate the new filter component. - Added loading state for filter operations. ### How to test? 1. Navigate to the Endpoint List Page. 2. Verify that the new filter component is visible next to the lifecycle stage filter. 3. Test filtering by endpoint name, service endpoint, and owner (if you have admin/superadmin privileges). 4. Confirm that the filter persists in the URL and works correctly when the page is refreshed. 5. Check that the loading indicator appears when applying filters. ### Why make this change? This change enhances the user experience by providing more granular control over endpoint filtering. It allows users to quickly find specific endpoints based on various criteria, improving efficiency in managing and monitoring endpoints, especially in environments with a large number of endpoints.
yomybaby
force-pushed
the
feature/endpoint-baipropertyfilter
branch
from
5734dfd to
228ea96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added advanced filtering capabilities to the Endpoint List Page.
What changed?
useQueryParam.How to test?
Why make this change?
This change enhances the user experience by providing more granular control over endpoint filtering. It allows users to quickly find specific endpoints based on various criteria, improving efficiency in managing and monitoring endpoints, especially in environments with a large number of endpoints.