Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce react progress bar for resource panel #2575

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Jul 25, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

ironAiken2 commented Jul 25, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ironAiken2 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:L 100~500 LoC label Jul 25, 2024
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
2.6% (-0.01% 🔻)
142/5463
🔴 Branches
2.75% (-0% 🔻)
101/3670
🔴 Functions
1.49% (-0% 🔻)
27/1816
🔴 Lines
2.48% (-0.01% 🔻)
133/5358
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / BAIResourcePanel.tsx
0% 0% 0% 0%
🔴
... / BAIProgressBar.tsx
0% 100% 0% 0%

Test suite run success

51 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 027f33b

@yomybaby yomybaby self-requested a review July 30, 2024 23:42
@ironAiken2 ironAiken2 force-pushed the feat/react-progress-bar branch 2 times, most recently from 70400f9 to 36dc52c Compare July 31, 2024 05:18
@ironAiken2 ironAiken2 changed the base branch from main to feat/ignore-per-container-config July 31, 2024 05:18
@yomybaby yomybaby changed the base branch from feat/ignore-per-container-config to graphite-base/2575 August 8, 2024 07:55
@yomybaby yomybaby force-pushed the feat/react-progress-bar branch from 36dc52c to 0141095 Compare August 8, 2024 07:57
@github-actions github-actions bot added area:lib Library and SDK related issue. area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC and removed size:L 100~500 LoC labels Aug 8, 2024
@yomybaby yomybaby changed the base branch from graphite-base/2575 to main August 8, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant