-
Notifications
You must be signed in to change notification settings - Fork 67
Disable FSI/PDI isolating on IE11 #178
base: master
Are you sure you want to change the base?
Conversation
@@ -14,7 +14,11 @@ import { documentReady, getResourceLinks, getMeta } from './util'; | |||
// used to create new `MessageContext` objects for a given `lang` with selected | |||
// builtin functions. | |||
function createContext(lang) { | |||
return new MessageContext(lang); | |||
// IE11 renders FSI and PDI as mojibakes so we turn them off. | |||
const isIE11 = navigator.userAgent.indexOf('Trident') > -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change that to:
const isIE = !!document.documentMode;
The less UA-sniffing the better; UA can always change while no browser should ever implement the non-standard document.documentMode
.
There is currently a bug in Edge as well which seems to be the same problem: It would be really nice if we could extend this solution to cover this Edge bug, too. |
There's an option, set Also, I'm in touch with the Edge team and apparently the bug is fixed in the upcoming Edge (part of the rs5 release). Not sure when it'll go public, but at least we know it'll be fixed now :) |
@zbraniecki Thanks for your answer! (Sorry to ask this here, if needed please point me to a better place to ask this, too. I could find no answer in the docs or Google. Thanks!) |
It's one of the options available on the constructor of |
Thank you for the hint @zbraniecki!
Thanks for your guidance! |
Microsoft seems to have abandoned the planned fix (6831905). |
IE11 on Windows renders FSI and PDI as mojibakes. Let's turn isolating off when this browser is detected.