Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwrite cached response headers with global options headers fields #163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Reeska
Copy link

@Reeska Reeska commented Mar 25, 2019

Hi,
I start to use your lib in my project that is working very well :).
But I have found a strange behaviour about headers.
In global and local options it's possible to overwrite headers: this works when request is not in cache, but no when request is cached.

I found a patch to overwrite headers with option headers in sendCachedResponse.

@coveralls
Copy link

coveralls commented Mar 25, 2019

Coverage Status

Coverage remained the same at 98.457% when pulling 23a2c52 on Reeska:master into 978af51 on kwhitley:master.

@stjosh stjosh mentioned this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants