Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GatewayAPI): support port in parentRef #10828

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jul 8, 2024
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 8, 2024 15:56
@michaelbeaumont michaelbeaumont requested review from slonka and jakubdyszkiewicz and removed request for a team July 8, 2024 15:56
@michaelbeaumont michaelbeaumont removed the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jul 9, 2024
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 thing I'm not sure about... 🤔

Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont merged commit d79cf9c into kumahq:master Jul 10, 2024
15 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/gapi-parent-ref-port branch July 10, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants