-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(MADR): reachable/autoreachable services with Mesh*Service #10737
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lukasz Dziedziak <[email protected]>
string name = 2; | ||
// Port of the targeted object. Required when kind is MeshService, MeshExternalService | ||
uint32 port = 3; | ||
// Namespace of the targeted object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not yet fully certain if this is necessary, as the name might already include this functionality. The name is a bit tricky because, once it's synced, it has a hash and namespace appended, which can cause a lot of confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should align with the backendRef of routes ultimately, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should, but I feel it might not. Currently, backendRef in a dataplane's outbound has a name in the format name-hash.namespace
(hash when synced), while backendRef in a route has name-hash
with the namespace in a separate field. That's why I am considering doing the same for outbounds.
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]> Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Checklist prior to review
We aim to provide feature parity for MeshService and MeshExternalService. One of the missing features is reachable services, and the goal is to provide some ideas and determine the best way to achieve that.
xrel: #10602
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --