Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(MADR): reachable/autoreachable services with Mesh*Service #10737

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jul 2, 2024

Checklist prior to review

We aim to provide feature parity for MeshService and MeshExternalService. One of the missing features is reachable services, and the goal is to provide some ideas and determine the best way to achieve that.

xrel: #10602

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lukidzi lukidzi requested a review from a team as a code owner July 2, 2024 15:25
@lukidzi lukidzi requested review from lobkovilya and Icarus9913 and removed request for a team July 2, 2024 15:25
@lukidzi lukidzi added ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) ci/skip-e2e-test PR: Don't run e2e tests labels Jul 2, 2024
string name = 2;
// Port of the targeted object. Required when kind is MeshService, MeshExternalService
uint32 port = 3;
// Namespace of the targeted object.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not yet fully certain if this is necessary, as the name might already include this functionality. The name is a bit tricky because, once it's synced, it has a hash and namespace appended, which can cause a lot of confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should align with the backendRef of routes ultimately, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, but I feel it might not. Currently, backendRef in a dataplane's outbound has a name in the format name-hash.namespace (hash when synced), while backendRef in a route has name-hash with the namespace in a separate field. That's why I am considering doing the same for outbounds.

@lukidzi lukidzi changed the title docs(madr): added madr how we should implement reachable services docs(MADR): added madr how we should implement reachable services Jul 2, 2024
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi requested a review from a team July 3, 2024 09:02
@lukidzi lukidzi changed the title docs(MADR): added madr how we should implement reachable services docs(MADR): reachable/autoreachable services with Mesh*Service Jul 3, 2024
Signed-off-by: Lukasz Dziedziak <[email protected]>
lukidzi and others added 3 commits July 4, 2024 10:20
Co-authored-by: Krzysztof Słonka <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants