chore(deps-dev): Bump vue-tsc from 2.0.21 to 2.0.28 #2784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [vue-tsc](https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc) from 2.0.21 to 2.0.28. - [Release notes](https://github.com/vuejs/language-tools/releases) - [Changelog](https://github.com/vuejs/language-tools/blob/master/CHANGELOG.md) - [Commits](https://github.com/vuejs/language-tools/commits/v2.0.28/packages/tsc) --- updated-dependencies: - dependency-name: vue-tsc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Superseded by #2805. |
johncowen
added a commit
that referenced
this pull request
Jul 30, 2024
…nts (#2795) Somewhere around vue language tools `2.0.18 - 2.0.21` all of the types for our `slots` suddenly stopped working. As this seemed to be a pretty big regression, I've been waiting to see if this would be addresses upstream seeing as various other type related bugs have also been fixed since `2.0.18`. I've waited for quite a while now, and I decided to take look to see if I could figure out exactly what the issue was, which led me to a fix/upgrade from our end. 1. At the beginning it was very much "anything further than 2.0.18 breaks our types (not knowing exactly why), hold off on upgrading for a bit and see what happens" 2. A few weeks back I'd realized that it seemed to be related to objects that DataSource was emitting via slots. DataSource also uses generic properties and some non-simple typescripting. 3. This morning I noticed that types were broken for the majority of our components, not just DataSource. 4. After trying some things out, I realised that if I imported DataSource instead of registering it globally, the types suddenly started to come back 🎉 , which led me to looking at how we register our global components. 5. After a bit of interweb sleuthing, it looks like we should no longer register global components on `@vue/runtime-core` but instead on `vue`. This PR contains the above change in point 5, plus another slight TS correction that was also causing errors in newer versions of `vue-tsc`. I've also tried this fix on ~#2784, #2805 and it will let us approve and merge that PR 🎉 Signed-off-by: John Cowen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps vue-tsc from 2.0.21 to 2.0.28.
Release notes
Sourced from vue-tsc's releases.
... (truncated)
Changelog
Sourced from vue-tsc's changelog.
... (truncated)
Commits
0cdbd70v2.0.28b4a8178chore: bump volarbc8521efix(tsc): TS4082 not reported for functional componentc0ec60afix(language-core): fix compatibility of generic component virtual code with ...5b53aeachore: bump volar67c2bf0chore(tsc): use throw instead ofconsole.errorce61a0dfix(language-core): preserve backward compatibilitye753366refactor(language-core): add getAllExtensions function519e916fix(language-core): getProjectVersion param has no effect47924f6v2.0.26Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)