Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Various form improvements #2771

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jul 22, 2024

  1. XAction type="" > action="". Using type as a Vue level attribute clashes with HTMLs button type=""
  2. Turn off the native bordering on fieldsets so we can start using them for disabling form sections entirely instead of disabling individual form elements. We also do this/make use of this now in the ZoneCreate form.
  3. Slight amends to DataSink:
    • Never use the cache for writing operations, we don't want a cached result.
    • Ensure writing 'in-flight' prop is always reset back to false after a write operation

Note: the above DataSink amends aren't crucial for the functionality we already use, but for a future functionality they will be.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 5b52a0f
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/669e3d549157c50008435b02
😎 Deploy Preview https://deploy-preview-2771--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: John Cowen <[email protected]>
@johncowen johncowen marked this pull request as ready for review July 22, 2024 13:49
@johncowen johncowen requested a review from a team as a code owner July 22, 2024 13:49
@johncowen johncowen self-assigned this Jul 23, 2024
@johncowen johncowen added this to the 2.9.x milestone Jul 24, 2024
@johncowen johncowen merged commit 924c7a5 into kumahq:master Jul 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants