fix: Alters main menu selection to not cause full re-render #2766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #2662 we moved the main navigation in App.vue to use
route.child()
for selection.I noticed that this is causing a full page re-render whenever the
route
is changed. You can notice this because our Github button in the header flickers on every single navigation (caused by the re-render). When navigating between tabbed sub-pages you shouldn't see a flicker (but you will do when navigation between Home, Zones, Meshes).Strangely
route.child()
doesn't cause full page re-renders in other areas, in fact it was used/made specifically to avoid full page re-renders.For the moment I've added a fix straight into
App.vue
that avoids the issue. But I would guess at some point I will come back to try and ensure thatroute.child()
or some iteration of it works consistently across all usages.