Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ensure every listing uses DataCollection #2764

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jul 16, 2024

Most of this was done in #2749, but after merging that I did another pass and found these 2 that were outstanding.

One of those were most of the change is down to re-nesting of HTML components.

Closes #2388

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 7187d22
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/66967cf1ad284000080465bf
😎 Deploy Preview https://deploy-preview-2764--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johncowen johncowen marked this pull request as ready for review July 16, 2024 16:36
@johncowen johncowen requested a review from a team as a code owner July 16, 2024 16:36
@johncowen johncowen self-assigned this Jul 16, 2024
@johncowen johncowen added this to the 2.9.x milestone Jul 23, 2024
@johncowen johncowen merged commit 6241487 into kumahq:master Jul 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use DataCollection for all listings
2 participants